-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[functional tests] Wait for url to update when removing all filters #11108
Conversation
jenkins, test this |
jenkins, test it |
jenkins, test it |
1 similar comment
jenkins, test it |
test/support/page_objects/common.js
Outdated
@@ -68,6 +68,13 @@ export default class Common { | |||
} | |||
} | |||
|
|||
waitUntilUrlFound(path) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about waitUntilUrlIncludes
to help indicate that this isn't looking for an exact match?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated in 09616e7
LGTM |
…lastic#11108) * [functional tests] Wait for url to update when removing all filters * [functional tests] waitUntilUrlFound -> waitUntilUrlIncludes
Attempt at fixing #11040. This waits for the url to update when removing all filters before future navigation.