Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[functional tests] Wait for url to update when removing all filters #11108

Merged
merged 2 commits into from
Apr 10, 2017

Conversation

jbudz
Copy link
Member

@jbudz jbudz commented Apr 7, 2017

Attempt at fixing #11040. This waits for the url to update when removing all filters before future navigation.

@jbudz jbudz self-assigned this Apr 7, 2017
@jbudz
Copy link
Member Author

jbudz commented Apr 7, 2017

jenkins, test this

@jbudz
Copy link
Member Author

jbudz commented Apr 7, 2017

jenkins, test it

@jbudz
Copy link
Member Author

jbudz commented Apr 7, 2017

jenkins, test it

1 similar comment
@jbudz
Copy link
Member Author

jbudz commented Apr 7, 2017

jenkins, test it

@@ -68,6 +68,13 @@ export default class Common {
}
}

waitUntilUrlFound(path) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about waitUntilUrlIncludes to help indicate that this isn't looking for an exact match?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated in 09616e7

@epixa
Copy link
Contributor

epixa commented Apr 10, 2017

LGTM

@epixa epixa added the test label Apr 10, 2017
@jbudz jbudz merged commit 6d254a3 into elastic:master Apr 10, 2017
@jbudz jbudz added the v5.3.2 label Apr 10, 2017
jbudz added a commit to jbudz/kibana that referenced this pull request Apr 10, 2017
…lastic#11108)

* [functional tests] Wait for url to update when removing all filters

* [functional tests] waitUntilUrlFound -> waitUntilUrlIncludes
@jbudz jbudz removed the v5.3.2 label Apr 10, 2017
jbudz added a commit that referenced this pull request Apr 10, 2017
…11108) (#11139)

* [functional tests] Wait for url to update when removing all filters

* [functional tests] waitUntilUrlFound -> waitUntilUrlIncludes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants